Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-EC2 targets with ob deploy #658

Merged
merged 9 commits into from
Mar 12, 2020
Merged

Conversation

3noch
Copy link
Collaborator

@3noch 3noch commented Feb 16, 2020

I have:

  • Based work on latest develop branch
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@3noch
Copy link
Collaborator Author

3noch commented Feb 16, 2020

module is a really bad name for this...

default.nix Outdated Show resolved Hide resolved
@HectorAE
Copy link
Collaborator

This will address #444 right?

@3noch
Copy link
Collaborator Author

3noch commented Feb 20, 2020

Right. You'd have to configure it properly but it should at least be trivial after this.

@3noch 3noch force-pushed the eac@config-deploy-module branch from 85efb59 to 6cd376b Compare March 11, 2020 20:09
@3noch 3noch force-pushed the eac@config-deploy-module branch from 1742e0e to 0ecf923 Compare March 12, 2020 18:28
@3noch 3noch force-pushed the eac@config-deploy-module branch from b14bbe9 to 445af77 Compare March 12, 2020 18:42
@3noch
Copy link
Collaborator Author

3noch commented Mar 12, 2020

Tested both on EC2 and VirtualBox

@3noch 3noch merged commit 9db8523 into develop Mar 12, 2020
@3noch
Copy link
Collaborator Author

3noch commented Mar 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants