Add obelisk profiling feature #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to add ‘Ob run’-like commands by factoring out important bits.
This adds profiled attr to set enableLibraryProfiling to true. If not set, it defaults to profiling arg.
This dumps some profiling information that can be viewed and used to debug Obelisk projects. ‘ob profile’ works like ob run, but instead of using ghci, it builds an executable that is built with profiling enabled.
This avoids polluting the root directory and gives some ability to reference multiple profiles.
This avoids a call every .1 seconds.
This module will always be there, and no need to add annotations. backend & frontend still get their annotations.
3noch
reviewed
Feb 11, 2020
This is unnecessary as we import immediately in the expression.
3noch
reviewed
Feb 11, 2020
3noch
reviewed
Feb 11, 2020
3noch
reviewed
Feb 11, 2020
3noch
reviewed
Feb 11, 2020
This avoids an issue with precedence in case of obRunExpr using $.
3noch
reviewed
Feb 11, 2020
This avoids having to mix up options for ob run and ob profile. Makes the way for adding a -o option to ob profile.
3noch
reviewed
Feb 11, 2020
3noch
reviewed
Feb 11, 2020
This avoids embedding this information into the binary.
This allow caching between ob profile runs.
Avoid showing it in the help documentation. Just do it when it is needed.
It seems safer to use an absolute path here. I originally assumed it would save it to the executable's directory, not the CWD. That's not the case, but the documentation leaves that behavior unspecified (https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/profiling.html#rts-flag--po%20%E2%9F%A8stem%E2%9F%A9), and I'd prefer to not have to debug it if it ever changes. |
3noch
reviewed
Feb 12, 2020
3noch
reviewed
Feb 18, 2020
This allows custom flags to be provided by the user. For instance, there are multiple types of heap profiles that can be used to get different information from ob profile. These can be added with the --rts-flags option.
This makes the default more obvious in the command line options.
- Use list of strings for rts args - Move time handling to the profile function, out of argument handling
3noch
reviewed
Feb 20, 2020
3noch
reviewed
Feb 20, 2020
dep/reflex-platform/github.json
Outdated
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "owner": "reflex-frp", | |||
| "repo": "reflex-platform", | |||
| "branch": "master", | |||
| "branch": "bump-reflex-0-6-4-1", | |||
There was a problem hiding this comment.
Once this is merged we should bump and then we can merge here.
adds: - profileRtsFlag - profileOutputFlag to avoid massively long lines.
3noch
reviewed
Feb 21, 2020
This file is just a static nix script. We can avoid hereDoc and just hit the attr directly. In addition, add the skeleton’s profiledObRun to the release.nix.
3noch
reviewed
Feb 21, 2020
pinBuildInputs tries to run binaries when they exist. We don’t want that, so we need to wrap it in a directory with $out/bin/ob-run containing the actual binary.
$out/bin/ob-run was a mistake
3noch
reviewed
Feb 24, 2020
3noch
reviewed
Feb 24, 2020
3noch
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds obelisk profile command. This dumps some profiling information into the profile/ directory that can give you some idea of what your program is spending resources on. Currently outputs 3 profiles:
I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)