Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all nix-builds with --sandbox #33

Closed
wants to merge 2 commits into from
Closed

Run all nix-builds with --sandbox #33

wants to merge 2 commits into from

Conversation

3noch
Copy link
Collaborator

@3noch 3noch commented May 29, 2018

Fixes #28

@3noch 3noch requested a review from ryantrinkle May 29, 2018 15:22
@3noch 3noch force-pushed the eac-nix-build-sandbox branch from 3898c99 to 6146b9e Compare May 29, 2018 15:26
@3noch
Copy link
Collaborator Author

3noch commented May 29, 2018

selftest is failing for some reason on this. I'll fix it.

@3noch
Copy link
Collaborator Author

3noch commented May 30, 2018

I think we'll need to run --sandbox on only certain builds. I haven't looked deeply into it yet but some things fail to build with this flag.

@ryantrinkle
Copy link
Member

Interesting; I'm surprised some things fail. I did add sandbox = true to the installation instructions, but having this as a fallback also seems good.

@ali-abrar
Copy link
Member

How does this relate to #55?

@alexfmpe
Copy link
Collaborator

alexfmpe commented Jun 7, 2018

I think the idea here is enforcing sandbox whenever possible.
#55 is more about the kind of sandbox that should be used (be it recommendation or enforcing).

ryantrinkle
ryantrinkle reviewed Jun 7, 2018
View reviewed changes
Copy link
Member

@ryantrinkle ryantrinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; does it work on mac?

@ryantrinkle
Copy link
Member

@3noch Looks like this needs to be rebased/merged.

@ryantrinkle
Copy link
Member

Also: should we be using 'relaxed' somehow?

@alexfmpe
Copy link
Collaborator

alexfmpe commented Jun 7, 2018 •
edited
Loading

Hard to say at this point - it may very well be that #6 also happens with 'relaxed'.
Also, neither setting seems to completely accept obelisk on macOS currently:
true -> #55 (comment)
relaxed -> #52 (comment)

@alexfmpe alexfmpe mentioned this pull request Jun 16, 2018
Merged
@3noch
Copy link
Collaborator Author

3noch commented Sep 28, 2018

Should we close this then? I don't think it's correct.

@hSloan hSloan added bug fix A pull request that fixes an existing bug follow up Follow up with Merge Requester to take some action labels Jan 22, 2019
@ali-abrar ali-abrar closed this Feb 10, 2019
ryantrinkle pushed a commit that referenced this pull request Aug 17, 2019
@hSloan
Merge pull request #33 from obsidiansystems/gitignore-attr-cache
6dcae3c 
Update gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrinkle ryantrinkle ryantrinkle left review comments

Assignees
No one assigned
Labels
bug fix A pull request that fixes an existing bug follow up Follow up with Merge Requester to take some action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@3noch @ryantrinkle @ali-abrar @alexfmpe @hSloan @luigy