Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin: Allow specifying an instance name filter #115

Merged

Conversation

jacobbaungard
Copy link
Contributor

This commit allow specifying the instance name filter, in order to filter the datasources shown on the dashboards.

This is similar to the change made in Thanos mixin here: thanos-io/thanos#6273

This commit allow specifying the instance name filter, in order to
filter the datasources shown on the dashboards.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode saswatamcode merged commit 1a5357d into observatorium:master Apr 13, 2023
@jacobbaungard jacobbaungard deleted the mixin-instance-name-filter branch April 13, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants