Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(tools): Revamped install-tools to not need it's own submodule #619

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Apr 6, 2022

Description of Changes

Removed tooling submodule and just added version go install commands to the Makefile

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@cpheps cpheps requested a review from a team as a code owner April 6, 2022 12:58
@cpheps cpheps requested a review from armstrmi April 6, 2022 12:58
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
jsirianni
jsirianni previously approved these changes Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@7073d30). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage        ?   74.92%           
=======================================
  Files           ?      133           
  Lines           ?    10089           
  Branches        ?        0           
=======================================
  Hits            ?     7559           
  Misses          ?     2062           
  Partials        ?      468           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7073d30...7d3a783. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com>
@cpheps cpheps merged commit ef0ab3e into main Apr 6, 2022
@cpheps cpheps deleted the tools-revamp branch April 6, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants