Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OS versions #617

Merged
merged 3 commits into from
Apr 5, 2022
Merged

added OS versions #617

merged 3 commits into from
Apr 5, 2022

Conversation

asenkowski
Copy link
Contributor

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@asenkowski asenkowski requested a review from jsirianni April 5, 2022 13:37
@asenkowski asenkowski requested a review from a team as a code owner April 5, 2022 13:37
@CLAassistant
Copy link

CLAassistant commented Apr 5, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@c4ccaa9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage        ?   74.91%           
=======================================
  Files           ?      133           
  Lines           ?    10089           
  Branches        ?        0           
=======================================
  Hits            ?     7558           
  Misses          ?     2065           
  Partials        ?      466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ccaa9...7eca9a9. Read the comment docs.

@cpheps
Copy link
Contributor

cpheps commented Apr 5, 2022

@asenkowski Going to submit a separate PR to fix the linter issue

README.md Show resolved Hide resolved
@cpheps
Copy link
Contributor

cpheps commented Apr 5, 2022

@asenkowski Should be good if you rebase or merge in main

@jsirianni jsirianni self-requested a review April 5, 2022 15:14
@asenkowski asenkowski merged commit 7073d30 into main Apr 5, 2022
@asenkowski asenkowski deleted the readme-os branch April 5, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants