Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action CI/CD Migration #553

Merged
merged 5 commits into from
Feb 16, 2022
Merged

GitHub Action CI/CD Migration #553

merged 5 commits into from
Feb 16, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Feb 16, 2022 •
edited
Loading

Description of Changes

  • Migrated Build, Release, and Test CI/CD to Github Action
  • Temporarily removed benchmark reporting and runs on CI. Will revisit later once we have a more reliable system.

Will turn off circle once this is merged.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

Corbin Phelps added 2 commits February 15, 2022 12:50
Refactored builds and tests into github actions
acf191a 
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Moved docker build and publish to github action
790e764 
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@cpheps cpheps requested a review from jsirianni February 16, 2022 15:31
@cpheps
Copy link
Contributor Author

cpheps commented Feb 16, 2022

Investigating CI/CD Issues

Corbin Phelps added 2 commits February 16, 2022 10:36
Fixed up issues with makefile and ci/cd
ce37c88 
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Updated readme badges
b63b0a7 
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
jsirianni
jsirianni previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I had a comment on caching. It could help speed up the build.

.github/workflows/multi_build.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
Added action caches
95369c4 
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@jsirianni jsirianni self-requested a review February 16, 2022 18:22
@cpheps cpheps merged commit 55abccb into master Feb 16, 2022
@cpheps cpheps deleted the github-actions branch February 16, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsirianni jsirianni jsirianni approved these changes

@dehaansa dehaansa dehaansa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpheps @dehaansa @jsirianni