Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: add ShiftJIS to supported encodings #546

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[WIP] feat: add ShiftJIS to supported encodings #546

merged 1 commit into from
Feb 15, 2022

Conversation

pea723
Copy link
Contributor

@pea723 pea723 commented Feb 15, 2022 •
edited by cpheps
Loading

Description of Changes

Add ShiftJIS (Japanese major encoding) to supported encodings.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@cpheps cpheps self-requested a review February 15, 2022 12:59
@cpheps
Copy link
Contributor

cpheps commented Feb 15, 2022

CI Failures are unreleated to this PR.

cpheps
cpheps approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpheps cpheps merged commit 3b23e5c into observIQ:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwilliams89 jmwilliams89 jmwilliams89 approved these changes

@cpheps cpheps cpheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pea723 @cpheps @jmwilliams89