Improved stanza logger flags and added log rotation #488
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
+ Coverage 74.32% 74.48% +0.16%
==========================================
Files 128 128
Lines 8225 8237 +12
==========================================
+ Hits 6113 6135 +22
+ Misses 1611 1609 -2
+ Partials 501 493 -8
Continue to review full report at Codecov.
|
|
Can we retain |
There was a problem hiding this comment.
LGTM. I Agree with @jsirianni though that we should keep the --debug flag for backwards compatibility.
| --plugin_dir The location of the plugins directory (default: ./plugins) | ||
| --database The location of the offsets database file. If this is not specified, offsets will not be maintained across agent restarts | ||
| --log_level The log level of the agent logger (default: INFO) | ||
| --log_file The location of the agent log file. If not specified, stanza will log to `stdout` | ||
| --max_log_size The maximum size of the agent log file in MB before rotating (default: 10) | ||
| --max_log_backups The maximum number of agent log files to retain when rotating (default: 5) | ||
| --max_log_age The maximum number of days to retain a rotated agent log file (default: 7) |
There was a problem hiding this comment.
I agree w/ @jsirianni's point about maintaining backwards compatibility for v1.x.
For v2, we should consider moving all of these into the config file.
There was a problem hiding this comment.
I had the same thought about the config file, since we're ending up with quite a few flags now. I decided against it because it was such a substantial change, but I agree we could probably fit it in for v2.
There was a problem hiding this comment.
Can we write a ticket for this in pivotal so it's captured?
There was a problem hiding this comment.
Captured this feature request here
|
Description of Changes
Please check that the PR fulfills these requirements