Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml parser #482

Merged
merged 9 commits into from
Nov 5, 2021
Merged

Xml parser #482

merged 9 commits into from
Nov 5, 2021

Conversation

armstrmi
Copy link
Contributor

@armstrmi armstrmi commented Nov 4, 2021

Description of Changes

  • Added XML-Parser Operator

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@armstrmi armstrmi requested a review from jmwilliams89 November 4, 2021 18:58
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6207191 +0.1551708 128.4414 -2.9709015
1 5000 5.000051 -0.12074661 139.17107 +2.7522888
1 10000 10.500242 -0.017010689 146.82246 +2.8048248
1 50000 53.10463 +0.43157196 185.60196 -2.3525085
1 100000 94.29444 -7.467308 229.92148 -8.571518
10 100 1.9828066 -0.03447044 132.75592 -2.059143
10 500 6.034547 -0.24157238 138.757 -0.33499146
10 1000 12.086316 -2.34513 150.76791 -1.0187225
10 5000 56.932384 -2.0277252 184.24986 +1.812088
10 10000 108.70068 -9.318306 231.30307 -8.309814

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #482 (279040b) into master (adad941) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   73.96%   74.17%   +0.21%     
==========================================
  Files         126      128       +2     
  Lines        8137     8219      +82     
==========================================
+ Hits         6018     6096      +78     
- Misses       1616     1623       +7     
+ Partials      503      500       -3     
Impacted Files Coverage Δ
operator/builtin/parser/xml/element.go 100.00% <100.00%> (ø)
operator/builtin/parser/xml/xml.go 100.00% <100.00%> (ø)
operator/builtin/input/file/file.go 77.16% <0.00%> (-1.52%) ⬇️
operator/builtin/output/forward/forward.go 60.49% <0.00%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adad941...279040b. Read the comment docs.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6897098 +0.2241615 129.47293 -1.9393768
1 5000 5.1208196 +2.193451e-05 136.95757 +0.53878784
1 10000 11.05178 +0.5345268 150.07193 +6.054291
1 50000 55.468185 +2.7951279 187.01576 -0.93870544
1 100000 90.98508 -10.776672 243.44464 +4.951645
10 100 2.0172126 -6.4373016e-05 134.90814 +0.09307861
10 500 6.103358 -0.17276144 139.87944 +0.78744507
10 1000 12.448761 -1.9826851 151.32611 -0.4605255
10 5000 55.27694 -3.6831703 189.75539 +7.3176117
10 10000 109.36464 -8.65435 234.41136 -5.201523

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4655347 -1.3589859e-05 129.52478 -1.8875275
1 5000 5.189648 +0.06885052 139.10062 +2.681839
1 10000 10.465566 -0.05168724 146.9014 +2.8837585
1 50000 55.294525 +2.6214676 182.17888 -5.775589
1 100000 110.2907 +8.528954 247.59995 +9.106949
10 100 1.9138235 -0.10345352 133.69127 -1.1237946
10 500 6.15529 -0.120829105 142.91083 +3.8188324
10 1000 12.62104 -1.8104057 152.05563 +0.2689972
10 5000 61.46718 +2.5070686 183.93184 +1.4940643
10 10000 109.101654 -8.9173355 240.70273 +1.0898438

CHANGELOG.md Outdated Show resolved Hide resolved
docs/operators/xml_parser.md Outdated Show resolved Hide resolved
operator/builtin/parser/xml/xml.go Outdated Show resolved Hide resolved
operator/builtin/parser/xml/xml.go Show resolved Hide resolved
operator/builtin/parser/xml/xml_test.go Show resolved Hide resolved
operator/builtin/parser/xml/xml_test.go Show resolved Hide resolved
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5000672 +0.034518957 132.33473 +0.9224243
1 5000 5.189679 +0.06888151 136.73398 +0.3152008
1 10000 10.638039 +0.12078571 147.65382 +3.6361847
1 50000 53.122055 +0.4489975 180.34698 -7.607483
1 100000 109.94719 +8.18544 254.67377 +16.18077
10 100 2.0000134 -0.01726365 132.34119 -2.473877
10 500 6.41397 +0.13785076 139.91002 +0.8180237
10 1000 11.845333 -2.586113 149.12648 -2.6601562
10 5000 59.03499 +0.07487869 180.44208 -1.995697
10 10000 103.510765 -14.5082245 231.55994 -8.052948

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4655479 -3.5762787e-07 130.8416 -0.5707092
1 5000 5.2932386 +0.172441 139.69788 +3.2790985
1 10000 10.569209 +0.051956177 150.0361 +6.018463
1 50000 52.863457 +0.19039917 182.21593 -5.7385406
1 100000 98.67286 -3.08889 232.35358 -6.1394196
10 100 1.9655595 -0.05171752 131.63524 -3.1798248
10 500 6.2070894 -0.06902981 139.77815 +0.6861572
10 1000 11.758739 -2.6727066 149.59119 -2.1954498
10 5000 56.0153 -2.944809 180.21889 -2.2188873
10 10000 113.70606 -4.3129272 240.48477 +0.8718872

@jmwilliams89 jmwilliams89 merged commit d9ec484 into master Nov 5, 2021
@jmwilliams89 jmwilliams89 deleted the xml-parser branch November 5, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants