Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_input should not write to db when deleting files #442

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

djaglowski
Copy link
Member

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.344888 -0.103408456 129.97212 +2.286377
1 5000 4.293094 -0.7760515 140.65706 +2.9255066
1 10000 9.517353 -0.65542316 141.67564 -0.5856781
1 50000 46.15607 +0.20759201 172.0221 -3.7212982
1 100000 92.41076 +1.1145935 244.00243 +7.4835663
10 100 2.0173051 +0.08626878 132.11409 -0.7157898
10 500 5.862171 -0.034642696 140.53476 -2.5669403
10 1000 11.000033 +0.051555634 146.7209 +5.466858
10 5000 51.000275 -4.7260666 179.24947 -1.8721619
10 10000 108.7158 +9.194611 225.74434 +10.11557

@jsirianni jsirianni self-requested a review September 20, 2021 21:59
@jsirianni jsirianni marked this pull request as ready for review September 20, 2021 21:59
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #442 (41a62f0) into master (c91388b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   72.74%   72.80%   +0.06%     
==========================================
  Files         126      126              
  Lines        8209     8209              
==========================================
+ Hits         5971     5976       +5     
+ Misses       1731     1721      -10     
- Partials      507      512       +5     
Impacted Files Coverage Δ
operator/builtin/input/file/file.go 76.44% <100.00%> (-2.09%) ⬇️
operator/builtin/output/newrelic/newrelic.go 74.38% <0.00%> (+0.83%) ⬆️
operator/builtin/output/otlp/otlp.go 68.13% <0.00%> (+3.30%) ⬆️
operator/builtin/input/tcp/tcp.go 78.72% <0.00%> (+3.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91388b...41a62f0. Read the comment docs.

@djaglowski djaglowski merged commit 6cb9877 into master Sep 20, 2021
@djaglowski djaglowski deleted the delete-skip-db branch September 20, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants