Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename_recall_period parameter to file_input #440

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Sep 20, 2021

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5172887 +0.06899226 125.76899 -1.9167557
1 5000 4.948582 -0.12056351 133.10547 -4.6260834
1 10000 9.655326 -0.51745033 147.81439 +5.55307
1 50000 47.276436 +1.3279572 174.36046 -1.3829346
1 100000 90.51911 -0.77705383 232.25053 -4.268326
10 100 2.0000088 +0.06897247 134.58136 +1.7514801
10 500 6.7414966 +0.8446827 137.62056 -5.48114
10 1000 11.086294 +0.13781643 145.90854 +4.6544952
10 5000 52.847786 -2.8785553 179.50592 -1.6157074
10 10000 98.81134 -0.7098465 219.70488 +4.076111

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4310678 -1.4830233 126.90113 -1.2324905
1 5000 5.2414966 -0.10348129 135.10803 -0.016830444
1 10000 9.758894 +0.37948036 142.05455 -4.18454
1 50000 45.552418 -1.120903 173.68184 -6.380661
1 100000 92.293915 +12.450577 231.75983 -476.82343
10 100 1.9655552 +0.06894207 134.91298 -0.28704834
10 500 5.8103523 +0.12064409 140.34645 -3.560608
10 1000 11.138134 +0.13807487 147.96512 +1.8230133
10 5000 51.838207 +0.68429565 184.2803 +1.2098541
10 10000 100.21464 +4.7071915 229.868 +6.2397614

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4655218 -1.4485693 131.04498 +2.9113617
1 5000 5.172543 -0.1724348 135.3055 +0.18063354
1 10000 9.55186 +0.17244625 143.22629 -3.0128021
1 50000 45.552742 -1.1205788 173.84833 -6.2141724
1 100000 90.39931 +10.555969 220.22508 -488.35815
10 100 2.0173163 +0.12070322 132.49219 -2.70784
10 500 5.7585635 +0.068855286 138.77545 -5.131607
10 1000 11.25878 +0.2587204 146.36543 +0.22332764
10 5000 50.483948 -0.66996384 176.14062 -6.929825
10 10000 97.00188 +1.4944305 220.36032 -3.2679138

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #440 (ca225a1) into master (6cb9877) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   72.81%   72.79%   -0.02%     
==========================================
  Files         126      126              
  Lines        8209     8215       +6     
==========================================
+ Hits         5977     5980       +3     
- Misses       1720     1722       +2     
- Partials      512      513       +1     
Impacted Files Coverage Δ
operator/builtin/input/file/config.go 81.63% <100.00%> (+0.19%) ⬆️
operator/builtin/input/file/file.go 77.04% <100.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb9877...ca225a1. Read the comment docs.

@djaglowski djaglowski marked this pull request as ready for review September 21, 2021 12:45
@jsirianni jsirianni self-requested a review September 21, 2021 15:37
@djaglowski djaglowski merged commit f4a2273 into master Sep 21, 2021
@djaglowski djaglowski deleted the file-recall branch September 21, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants