-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudwatch multi group #420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
djaglowski
approved these changes
Sep 14, 2021
|
jsirianni
pushed a commit
to observIQ/bindplane-otel-collector
that referenced
this pull request
Sep 16, 2021
2 tasks
schmikei
added a commit
to observIQ/bindplane-otel-collector
that referenced
this pull request
Sep 16, 2021
* port observIQ/stanza#420 * fix goconst linter errors * return nil * read and write the same persistence key * we do not want an error when no previous checkpoint exists Co-authored-by: schmikei <keith.schmitt@bluemedora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We need to merge Go 1.17 first, in order to resolve a CI failure: #421
The primary goal is to support multiple AWS cloudwatch groups with a single configuration.
log_groups
parameter, for defining a static listlog_group_prefix
for dynamically detecting log groupsconfigureSession
method for aws session re-use, instead of creating a session for each log grouplog_group_name
,log_groups
, andlog_group_prefix
can all be used together. Their values are merged intolog_groups
.What is missing?
There is no upper limit to number of log groups. If we think we need to, we could add the same logic that file_input uses for managing max number of open files. This logic could be added in a follow up PR, allowing us to deliver a working implementation quickly.
Please check that the PR fulfills these requirements