Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify recent gcloud sdk version #408

Merged
merged 1 commit into from
Aug 25, 2021
Merged

specify recent gcloud sdk version #408

merged 1 commit into from
Aug 25, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 25, 2021

Description of Changes

Benchmarks fail because the circle ci gcloud orb is installing an old version of the sdk.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni requested a review from djaglowski August 25, 2021 13:25
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.2931514 -0.18965411 128.29149 +0.5346222
1 5000 5.4312687 +0.27601147 135.67538 -3.4715729
1 10000 9.775994 -0.3102951 144.60117 -3.9170227
1 50000 51.48209 +4.069916 175.26158 -0.6016998
1 100000 99.79403 -6.73967 233.98195 -7.2459564
10 100 2.0171952 -0.034567595 135.10493 -1.337143
10 500 5.862134 -0.4656191 139.61153 +2.0625
10 1000 12.396796 -1.3104143 146.04903 -0.015899658
10 5000 55.532516 -4.6750145 181.59119 +2.0654602
10 10000 110.52371 +7.4192047 240.71431 +20.952057

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #408 (c34dec1) into master (0a9d718) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   72.99%   73.08%   +0.09%     
==========================================
  Files         124      124              
  Lines        8071     8071              
==========================================
+ Hits         5891     5898       +7     
+ Misses       1674     1666       -8     
- Partials      506      507       +1     
Impacted Files Coverage Δ
operator/buffer/memory.go 80.00% <0.00%> (+4.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a9d718...c34dec1. Read the comment docs.

@jsirianni jsirianni merged commit 4a35465 into master Aug 25, 2021
@jsirianni jsirianni deleted the fix-gcloud-sdk branch August 25, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants