Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls min version #400

Merged
merged 4 commits into from
Aug 21, 2021
Merged

Tls min version #400

merged 4 commits into from
Aug 21, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 21, 2021

Description of Changes

Golang's crypto/tls defaults to a minimum version of tls 1.0. This allows any modern client to connect without issue. A restricted environment may require a minimum version of 1.2 or 1.3. This PR allows the user to specify a minimum supported version.

  • Added min_version parameter for the tls configuration
  • Documented TLS configuration

Resolves #349

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.482797 -0.051807523 131.69922 -2.3003845
1 5000 5.2242866 +0.22426271 140.01535 +1.727768
1 10000 10.258737 -0.24145985 144.09456 -1.2337036
1 50000 50.741283 +0.5165062 172.07475 -6.79216
1 100000 99.78102 +5.468277 237.77277 +6.901947
10 100 1.9827248 +0.051662445 132.93494 +0.41540527
10 500 6.172565 +0.1896863 139.1161 -2.8112946
10 1000 12.0346985 +1.2070751 148.37218 +1.8178864
10 5000 57.73127 +4.8517876 181.43764 +1.5689697
10 10000 106.08623 -3.8731232 221.6091 -10.073547

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #400 (cb04e71) into master (47e0a8b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files         124      124           
  Lines        7999     8011   +12     
=======================================
+ Hits         5859     5868    +9     
- Misses       1639     1645    +6     
+ Partials      501      498    -3     
Impacted Files Coverage Δ
operator/builtin/input/tcp/tcp.go 78.57% <100.00%> (+2.01%) ⬆️
operator/builtin/output/otlp/otlp.go 64.84% <0.00%> (-3.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e0a8b...cb04e71. Read the comment docs.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4483001 -0.086304426 128.42497 -5.5746307
1 5000 5.1724963 +0.17247248 137.90248 -0.38510132
1 10000 10.482979 -0.017217636 145.83176 +0.50349426
1 50000 49.725174 -0.49960327 175.7632 -3.103714
1 100000 97.53961 +3.2268677 235.27505 +4.404236
10 100 2.0690901 +0.13802779 132.65706 +0.13752747
10 500 5.8104067 -0.172472 139.86476 -2.0626373
10 1000 13.345135 +2.5175114 145.70502 -0.8492737
10 5000 54.788715 +1.9092331 181.7566 +1.8879395
10 10000 111.062355 +1.1030045 229.57059 -2.1120605

@jsirianni jsirianni marked this pull request as ready for review August 21, 2021 01:42
@jsirianni jsirianni merged commit 4a234f9 into master Aug 21, 2021
@jsirianni jsirianni deleted the tls-min-version branch August 21, 2021 03:01
@jsirianni jsirianni mentioned this pull request Aug 24, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable min TLS version
2 participants