Label regex persistence #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aderLabels are persisted to the datbase
|
Codecov Report
@@ Coverage Diff @@
## file-input-label-regex #399 +/- ##
==========================================================
- Coverage 73.06% 73.04% -0.02%
==========================================================
Files 124 124
Lines 8041 8043 +2
==========================================================
Hits 5875 5875
- Misses 1662 1663 +1
- Partials 504 505 +1
Continue to review full report at Codecov.
|
djaglowski
approved these changes
Aug 21, 2021
jsirianni
pushed a commit
that referenced
this pull request
Aug 21, 2021
* add label regex param, for parsing file headers * make readHeaders private. do not use reader's fingerprint, instead open the file directly and parse headers * add label_regex.yaml to test configs * combine label_regex length checks * call readHeaders from readHeaders, to avoid calling readHeaders on every poll cycle * add type consumerFunc func(context.Context, []byte) error so we can share the same reader for reading the headers and file * do not modify offset as it was never set * enhance regex check to allow reversed capture groups * file_input: Added optional LabelRegex parameter * move fingerprint header labels to Reader type. Add logic to ensure HeaderLabels are persisted to the datbase (#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR is going to merge into
file-input-lables-regexbranch which is already approved.fingerprint.LabelstoReader.HeaderLabelsFingerprinttype)Reader.HeaderLabelsare persisted to the database by adding a deep copy to theReader.CopymethodMotivation
On branch
file-input-label-regex, everything is working except label persistence. When the agent is restarted, all new log entries are missing their HeaderLabels. This PR ensures header labels are persisted with the Reader.Results
Please check that the PR fulfills these requirements