Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update k8s.io to v0.22.0 #377

Merged
merged 1 commit into from
Aug 19, 2021
Merged

update k8s.io to v0.22.0 #377

merged 1 commit into from
Aug 19, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 12, 2021

Description of Changes

When upgrading one k8s.io module at a time, builds fail. This is because the 3 modules should be versioned together, per this thread.

Supersedes #373
Supersedes #372

Kubernetes functionality is working well:

{
  "timestamp": "2021-08-12T02:46:30.18505116Z",
  "severity": 30,
  "severity_text": "stdout",
  "labels": {
    "k8s-pod/app": "mongo",
    "k8s-pod/pod-template-hash": "5bbd5cdd6b",
    "log_type": "k8s.container",
    "plugin_id": "kubernetes_container",
    "stream": "stdout"
  },
  "resource": {
    "k8s.cluster.name": "stanza_example",
    "k8s.container.id": "3c6c2842486d57dd600895ab7e106e8371b16c37861779cd2f8a97c1ac8041f5",
    "k8s.container.name": "wordpress",
    "k8s.deployment.name": "mongodb",
    "k8s.namespace.name": "default",
    "k8s.namespace.uid": "3860b3e2-f894-42f5-8af0-e634187299d8",
    "k8s.node.name": "",
    "k8s.pod.name": "mongodb-5bbd5cdd6b-vpx8r",
    "k8s.pod.uid": "4e8fab46-05b7-4938-9eda-e4bee7ce9033",
    "k8s.replicaset.name": "mongodb-5bbd5cdd6b"
  },
  "record": {
    "attr": {
      "message": "[1628736390:181995][1:0x7fd1d1c43700], WT_SESSION.checkpoint: [WT_VERB_CHECKPOINT_PROGRESS] saving checkpoint snapshot min: 3, snapshot max: 3 snapshot count: 0, oldest timestamp: (0, 0) , meta checkpoint timestamp: (0, 0) base write gen: 7"
    },
    "c": "STORAGE",
    "ctx": "Checkpointer",
    "id": 22430,
    "msg": "WiredTiger message",
    "s": "I",
    "t": {
      "$date": "2021-08-12T02:46:30.182+00:00"
    }
  }
}

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4310386 -0.10345316 128.53825 -0.3203125
1 5000 5.2760024 +0.32764435 138.06479 +0.102371216
1 10000 9.982824 -0.8796263 142.93803 +0.6000824
1 50000 52.777298 -0.4470253 180.69922 +3.567215
1 100000 97.1923 -3.153099 234.98546 +0.44047546
10 100 1.9138207 -0.034512877 133.97575 -1.6147614
10 500 6.172501 -0.51728153 137.24448 -3.107483
10 1000 12.464651 +0.3092518 146.78825 +0.5808258
10 5000 61.501305 +5.775421 184.3478 +4.938843
10 10000 106.13978 -2.6352463 223.5594 -8.861664

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #377 (58c184f) into master (7f94b79) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   73.30%   73.31%   +0.01%     
==========================================
  Files         124      124              
  Lines        7977     7977              
==========================================
+ Hits         5847     5848       +1     
  Misses       1635     1635              
+ Partials      495      494       -1     
Impacted Files Coverage Δ
operator/builtin/input/file/reader.go 69.30% <0.00%> (-1.75%) ⬇️
operator/builtin/output/forward/forward.go 60.49% <0.00%> (-1.23%) ⬇️
operator/builtin/input/file/file.go 81.15% <0.00%> (+0.52%) ⬆️
operator/builtin/output/otlp/otlp.go 68.13% <0.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f94b79...58c184f. Read the comment docs.

@jsirianni jsirianni marked this pull request as ready for review August 12, 2021 02:47
@jsirianni jsirianni requested a review from schmikei August 12, 2021 02:47
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the changelog and think we should be good since these libraries are tightly coupled with the main kubernetes branch.
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.22.md

@jsirianni jsirianni merged commit 6558669 into master Aug 19, 2021
@jsirianni jsirianni deleted the k8s.io-modules branch August 19, 2021 23:57
@jsirianni jsirianni mentioned this pull request Aug 24, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants