-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csv header delimiter #370
Csv header delimiter #370
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 73.28% 73.22% -0.05%
==========================================
Files 124 124
Lines 7974 7977 +3
==========================================
- Hits 5843 5841 -2
- Misses 1638 1643 +5
Partials 493 493
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Description of Changes
In rare situations, it can be useful to specify the delimiter being used in your config for the
header
field.A future PR will bring support for tab delimited CSV data. This means the config would require a tab delimited header value:
This can be awkward to configure. Allowing the header delimiter to be set removes this issue.
Please check that the PR fulfills these requirements