Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File input: Quiet close error #345

Merged
merged 3 commits into from
Jun 25, 2021
Merged

File input: Quiet close error #345

merged 3 commits into from
Jun 25, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jun 25, 2021

Description of Changes

Skip closing files already closed, same as open-telemetry/opentelemetry-log-collection#174

This pr builds on

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.3793627 -0.120655656 128.35736 +1.6651459
1 5000 5.4656396 +0.74136734 137.70273 -2.5342102
1 10000 9.344765 -1.7075472 140.69788 -2.9505615
1 50000 49.65387 +4.3796005 170.93561 -0.93414307
1 100000 97.00854 +4.883545 221.13362 -16.63443
10 100 1.8793787 +0.08619225 132.62271 -0.87620544
10 500 5.931199 +0.5691061 139.71538 -0.63012695
10 1000 11.448379 -0.5348129 147.10655 -1.4383087
10 5000 49.12108 -6.639618 174.5687 -3.4773712
10 10000 105.87744 +6.639305 225.67148 -9.0546875

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #345 (2780d31) into master (baa994e) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   69.68%   69.56%   -0.12%     
==========================================
  Files         123      123              
  Lines        6491     6491              
==========================================
- Hits         4523     4515       -8     
- Misses       1492     1501       +9     
+ Partials      476      475       -1     
Impacted Files Coverage Δ
operator/builtin/input/file/file.go 73.61% <ø> (-0.18%) ⬇️
operator/builtin/input/file/config.go 75.38% <100.00%> (-2.74%) ⬇️
logger/parser.go 56.52% <0.00%> (-17.39%) ⬇️
operator/builtin/input/file/reader.go 66.67% <0.00%> (-1.19%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa994e...2780d31. Read the comment docs.

@jsirianni jsirianni mentioned this pull request Jun 25, 2021
4 tasks
@jsirianni jsirianni marked this pull request as ready for review June 25, 2021 16:39
@jsirianni jsirianni merged commit ffd6dcd into master Jun 25, 2021
@jsirianni jsirianni deleted the quiet-close-error branch June 25, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants