Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot #305

Merged
merged 1 commit into from
May 19, 2021
Merged

add dependabot #305

merged 1 commit into from
May 19, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented May 18, 2021

Description of Changes

See https://github.com/open-telemetry/opentelemetry-log-collection/pull/102/files

This configuration assumes that we will have a go module in / and /internal/tools. Right now we use sub modules but this PR #304 will change that.

I also intend to update make install-tools to behave like this https://github.com/open-telemetry/opentelemetry-log-collection/blob/main/Makefile, which will add the /internal/tools module.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni requested review from schmikei and ericwholt May 18, 2021 21:26
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.413803 -0.27582216 130.22037 +0.7980957
1 5000 5.206998 -0.58610153 137.30348 +1.9892273
1 10000 10.793177 +0.3275938 143.93831 -0.7932434
1 50000 53.513657 +3.3931465 177.74232 +4.306305
1 100000 102.74363 +1.3327713 241.48384 +7.514282
10 100 1.9139125 -0.034379482 138.53462 +5.440201
10 500 6.1382465 -0.37907076 138.70541 -0.7258911
10 1000 13.448412 +1.6724052 147.70447 +1.6403503
10 5000 55.38057 -0.9144325 184.72427 -0.9801941
10 10000 106.23394 +0.26838684 223.34886 -0.1857605

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #305 (d80bffd) into master (a7077d1) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   69.43%   69.37%   -0.06%     
==========================================
  Files         119      119              
  Lines        6291     6291              
==========================================
- Hits         4368     4364       -4     
  Misses       1456     1456              
- Partials      467      471       +4     
Impacted Files Coverage Δ
operator/builtin/input/tcp/tcp.go 66.67% <0.00%> (-4.76%) ⬇️
operator/flusher/flusher.go 84.00% <0.00%> (-4.00%) ⬇️
operator/builtin/output/forward/forward.go 56.52% <0.00%> (+1.45%) ⬆️
operator/builtin/output/otlp/otlp.go 65.43% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7077d1...d80bffd. Read the comment docs.

Copy link
Contributor

@ericwholt ericwholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsirianni jsirianni merged commit 99da4f1 into master May 19, 2021
@jsirianni jsirianni deleted the dependabot branch May 19, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants