Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port copy operator #278

Merged
merged 9 commits into from
May 7, 2021
Merged

Port copy operator #278

merged 9 commits into from
May 7, 2021

Conversation

Mrod1598
Copy link
Contributor

@Mrod1598 Mrod1598 commented Apr 16, 2021

Description of Changes

Ported the copy operator from the decomposition of the restructure operator discussed here: OpenTelementry#68.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.517267 +0.086159945 123.46471 -1.5402756
1 5000 5.069 -0.22423983 132.36813 +0.6053314
1 10000 10.534681 +0.05178833 140.22589 -1.613678
1 50000 49.414505 -1.9135361 168.88281 -3.4187775
1 100000 101.15273 +0.7429428 244.03624 -1.515213
10 100 1.9137586 -0.051844478 130.04822 +1.9942017
10 500 6.310247 +0.1722455 135.76819 +2.300644
10 1000 11.603522 -0.22446632 141.71605 -0.9181061
10 5000 56.207355 -0.5174866 184.31479 +4.580017
10 10000 107.20577 +1.0642929 219.5594 -4.530304

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #278 (cdf9121) into master (dbd2f09) will decrease coverage by 0.04%.
The diff coverage is 63.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   70.63%   70.59%   -0.04%     
==========================================
  Files         114      115       +1     
  Lines        6027     6046      +19     
==========================================
+ Hits         4257     4268      +11     
+ Misses       1322     1321       -1     
- Partials      448      457       +9     
Impacted Files Coverage Δ
operator/builtin/transformer/copy/copy.go 63.16% <63.16%> (ø)
operator/builtin/input/tcp/tcp.go 66.67% <0.00%> (-4.76%) ⬇️
operator/flusher/flusher.go 84.00% <0.00%> (-4.00%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️
operator/builtin/output/forward/forward.go 56.52% <0.00%> (+1.45%) ⬆️
operator/builtin/input/file/file.go 76.03% <0.00%> (+2.05%) ⬆️
operator/builtin/output/otlp/otlp.go 65.43% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd2f09...cdf9121. Read the comment docs.

@Mrod1598 Mrod1598 requested a review from dehaansa April 16, 2021 19:04
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to init_common.go

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.3793133 -0.20690298 124.81964 +3.2000275
1 5000 4.8448653 -0.24154663 133.78973 +0.37580872
1 10000 10.810635 +0.37926865 141.22832 +1.4151459
1 50000 51.053776 +2.4496613 173.20663 +1.4455872
1 100000 106.60752 +10.060059 237.53745 +2.2064972
10 100 2.0518165 -0.051678658 128.77316 +0.65597534
10 500 6.241093 +0.4305668 137.8657 +1.6773987
10 1000 12.2930975 +0.01702404 141.92188 +0.104522705
10 5000 57.604378 -1.450943 184.48047 +5.0429688
10 10000 106.53511 -2.9125671 220.20676 -11.047287

@jsirianni jsirianni requested review from jsirianni and removed request for dehaansa May 7, 2021 18:03
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.603458 -0.03447056 124.72832 -1.3413239
1 5000 5.482732 +0.534328 132.90881 -3.4089355
1 10000 10.63837 +0.17281532 137.19437 -3.6677094
1 50000 49.5695 +1.6236382 168.29944 -1.9325104
1 100000 99.822105 +5.1144333 239.09819 +5.6578674
10 100 1.9483058 -0.46560693 128.89629 -1.0236969
10 500 6.241528 -0.17256355 137.96983 +0.4993286
10 1000 11.741637 -0.13770294 142.53569 +1.7512054
10 5000 55.672974 +6.997181 182.1421 +0.13806152
10 10000 103.595825 -2.8392105 208.67525 -13.643723

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.7241694 +0.08624077 126.76899 +0.69934845
1 5000 5.396597 +0.44819307 132.60184 -3.7159119
1 10000 10.569178 +0.10362339 141.33513 +0.47305298
1 50000 51.05055 +3.1046867 172.44101 +2.2090607
1 100000 98.96789 +4.2602158 237.31007 +3.869751
10 100 1.9138293 -0.50008345 126.71094 -3.2090454
10 500 6.275981 -0.13811064 139.47374 +2.0032349
10 1000 12.431404 +0.55206394 141.49542 +0.7109375
10 5000 56.01252 +7.336727 181.04257 -0.96147156
10 10000 107.27504 +0.84000397 227.2411 +4.9221344

@Mrod1598 Mrod1598 merged commit 012b857 into master May 7, 2021
@jsirianni jsirianni deleted the port-copy-operator branch July 13, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants