Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port remove operator #273

Merged
merged 5 commits into from
May 7, 2021
Merged

Port remove operator #273

merged 5 commits into from
May 7, 2021

Conversation

Mrod1598
Copy link
Contributor

@Mrod1598 Mrod1598 commented Apr 12, 2021

Description of Changes

Ported the remove operator from the decomposition of the restructure operator discussed here: OpenTelementry#68.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@Mrod1598 Mrod1598 requested a review from dehaansa April 12, 2021 22:10
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #273 (112cf10) into master (37ab164) will decrease coverage by 0.10%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   70.56%   70.46%   -0.10%     
==========================================
  Files         112      113       +1     
  Lines        5961     5978      +17     
==========================================
+ Hits         4206     4212       +6     
- Misses       1307     1319      +12     
+ Partials      448      447       -1     
Impacted Files Coverage Δ
operator/builtin/transformer/remove/remove.go 58.82% <58.82%> (ø)
operator/builtin/output/otlp/otlp.go 61.73% <0.00%> (-3.70%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ab164...112cf10. Read the comment docs.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.7931558 -0.06893468 124.4608 +0.8573532
1 5000 6.172554 +0.13796473 131.77478 -0.713501
1 10000 12.965435 +0.6547613 140.22118 -1.6248627
1 50000 58.156055 -1.5015106 172.42296 -1.1283569
1 100000 115.92519 -3.9558487 238.09523 +15.527481
10 100 2.275932 -0.22413826 127.113686 -1.0043106
10 500 7.189973 +0.25876236 135.94046 -0.019134521
10 1000 13.17272 -0.5516777 142.15652 -1.5013428
10 5000 63.705906 -0.0023269653 185.62137 +0.25593567
10 10000 127.56461 +2.0475845 218.16446 -9.290817

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to init_common.go

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5862378 +2.1457672e-05 125.86705 +4.2474365
1 5000 5.4309583 +0.34454632 135.4111 +1.9971771
1 10000 10.551889 +0.12052345 139.23007 -0.58309937
1 50000 54.726067 +6.121952 170.36598 -1.3950653
1 100000 98.89032 +2.3428574 236.99947 +1.6685181
10 100 2.0173075 -0.0861876 130.7236 +2.6064148
10 500 6.569235 +0.7587085 132.01845 -4.169861
10 1000 12.189819 -0.08625412 143.2267 +1.4093475
10 5000 52.794224 -6.261097 181.63309 +2.1955872
10 10000 109.867355 +0.41967773 219.50742 -11.746628

@Mrod1598 Mrod1598 requested review from jsirianni and removed request for dehaansa May 7, 2021 17:54
@jsirianni jsirianni merged commit dbd2f09 into master May 7, 2021
@jsirianni jsirianni deleted the port-remove-operator branch May 7, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants