Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port move operator #271

Merged
merged 17 commits into from
May 7, 2021
Merged

Port move operator #271

merged 17 commits into from
May 7, 2021

Conversation

Mrod1598
Copy link
Contributor

@Mrod1598 Mrod1598 commented Apr 12, 2021

Description of Changes

Ported the move operator from the decomposition of the restructure operator discussed here: OpenTelementry#68.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski djaglowski requested a review from dehaansa April 12, 2021 18:07
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6896927 -0.17239773 123.38241 -0.22103882
1 5000 6.27609 +0.24150085 131.0555 -1.432785
1 10000 11.983028 -0.3276453 139.9336 -1.9124451
1 50000 56.966564 -2.691002 171.21283 -2.3384857
1 100000 115.17785 -4.7031937 230.91621 +8.348465
10 100 2.2931852 -0.2068851 126.77694 -1.3410568
10 500 7.1380424 +0.20683193 132.51132 -3.4482727
10 1000 14.241667 +0.51726913 145.0322 +1.3743286
10 5000 64.48432 +0.7760887 179.54526 -5.820175
10 10000 124.83807 -0.6789551 222.34294 -5.112335

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #271 (3e32afb) into master (012b857) will decrease coverage by 0.11%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   70.61%   70.50%   -0.11%     
==========================================
  Files         115      116       +1     
  Lines        6046     6064      +18     
==========================================
+ Hits         4269     4275       +6     
- Misses       1318     1324       +6     
- Partials      459      465       +6     
Impacted Files Coverage Δ
operator/builtin/transformer/move/move.go 61.11% <61.11%> (ø)
operator/builtin/output/otlp/otlp.go 62.96% <0.00%> (-2.47%) ⬇️
operator/builtin/input/file/file.go 73.97% <0.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012b857...3e32afb. Read the comment docs.

dehaansa
dehaansa previously approved these changes Apr 13, 2021
@djaglowski
Copy link
Member

We also need to add new operators to the cmd/stanza/init_common.go so they are available downstream.

djaglowski
djaglowski previously approved these changes May 6, 2021
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's update and see CI pass again, then can merge.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5862423 +0.06896734 122.5136 -2.076645
1 5000 5.241459 +0 133.27896 +0
1 10000 10.275986 +0 140.65558 +0
1 50000 50.156326 +1.1244469 172.9841 +3.391159
1 100000 97.46698 -0.3278427 238.18413 -2.5128021
10 100 2.0344267 +0.1205703 127.43023 -2.729927
10 500 5.8450174 -0.22403193 138.14749 +1.5717926
10 1000 11.931208 +0 143.54068 +0
10 5000 54.19571 +0 177.1836 +0
10 10000 109.28677 +0 224.62743 +0

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4655311 -0.051743865 124.404366 -0.18588257
1 5000 5.1035805 +0 135.41325 +0
1 10000 11.086394 +0 139.64076 +0
1 50000 50.188362 +1.1564827 173.6149 +4.0219574
1 100000 96.31366 -1.481163 225.01886 -15.67807
10 100 1.8793383 -0.034518123 127.99946 -2.160698
10 500 5.9655585 -0.10349083 135.0004 -1.5753021
10 1000 11.638212 +0 141.63766 +0
10 5000 55.673115 +0 184.0163 +0
10 10000 109.93526 +0 222.97871 +0

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.7069343 +0.06900573 123.64898 -2.420662
1 5000 5.7068667 +0.7584629 132.7403 -3.5774536
1 10000 10.827789 +0.36223507 143.40033 +2.5382538
1 50000 50.362038 +2.4161758 173.83984 +3.607895
1 100000 100.10615 +5.3984756 235.64157 +2.2012482
10 100 1.9655377 -0.4483751 128.967 -0.9529877
10 500 5.6899443 -0.7241473 135.26132 -2.2091827
10 1000 11.293228 -0.586112 144.80739 +4.0229034
10 5000 55.796555 +7.120762 182.9569 +0.95285034
10 10000 108.3686 +1.9335632 219.98788 -2.3310852

@jsirianni jsirianni self-requested a review May 7, 2021 18:19
jsirianni
jsirianni previously approved these changes May 7, 2021
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4482796 -0.12066913 124.49354 -0.78245544
1 5000 5.37938 -0.10344696 132.92188 -1.4539337
1 10000 10.465633 -0.17259979 140.3327 -2.9105682
1 50000 51.36259 -0.8956413 172.00983 -1.0549622
1 100000 95.05556 -2.909935 223.15881 -3.6895142
10 100 1.9655609 -0.017257452 128.53125 -3.4125824
10 500 6.396711 +0.12077093 135.87689 +1.1002197
10 1000 12.069041 +0.017261505 141.3296 -3.8355408
10 5000 56.15531 +2.6285057 184.24596 +5.1608276
10 10000 109.346535 -9.241562 222.60709 -4.5072784

@jsirianni jsirianni self-requested a review May 7, 2021 18:46
@jsirianni jsirianni merged commit df31714 into master May 7, 2021
@jsirianni jsirianni deleted the port-move-operator branch July 13, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants