Make proxy optional for k8s_metadata_decorator #239
Merged
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 31, 2020 12:42
disabling the use of a proxy for this operator. Generally, you would not want to use a proxy for connections to the Kubernetes API. The Kubernetes client, by default, will use any proxy set at HTTP_PROXY or HTTPS_PROXY unless the proxy function is set. supporting docs: - https://godoc.org/k8s.io/client-go/rest#Config - https://golang.org/pkg/net/http/#ProxyFromEnvironment resolves #238
|
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 71.36% 71.27% -0.09%
==========================================
Files 101 101
Lines 5538 5542 +4
==========================================
- Hits 3952 3950 -2
- Misses 1165 1166 +1
- Partials 421 426 +5
Continue to review full report at Codecov.
|
djaglowski
approved these changes
Jan 4, 2021
…nicating with the k8s api
|
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added
allow_proxyoption (default: false) for enabling or disabling the use of a proxy for the k8s_metadata_decorator operator.Generally, you would not want to use a proxy for connections to the Kubernetes API, however, the Kubernetes client will use any proxy set at HTTP_PROXY or HTTPS_PROXY unless the proxy function is set.
This is a problem because the proxy is likely not inside the cluster, therefore it cannot forward requests to the internal Kubernetes APIs.
supporting docs:
More context here: resolves #238
Please check that the PR fulfills these requirements