Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flusher Timeout #231

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Flusher Timeout #231

merged 5 commits into from
Dec 10, 2020

Conversation

djaglowski
Copy link
Member

Description of Changes

Flushers will now give up on retries eventually, rather than loop indefinitely.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #231 (df25c9e) into master (8ed70f8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   71.22%   71.26%   +0.04%     
==========================================
  Files         100      100              
  Lines        5518     5518              
==========================================
+ Hits         3930     3932       +2     
+ Misses       1168     1165       -3     
- Partials      420      421       +1     
Impacted Files Coverage Δ
operator/flusher/flusher.go 84.00% <100.00%> (+6.00%) ⬆️
operator/builtin/input/file/file.go 72.60% <0.00%> (-2.05%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️
operator/builtin/output/otlp/otlp.go 65.43% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed70f8...df25c9e. Read the comment docs.

@djaglowski djaglowski requested a review from andykellr December 8, 2020 20:36
@djaglowski djaglowski marked this pull request as ready for review December 8, 2020 20:36
@djaglowski
Copy link
Member Author

djaglowski commented Dec 9, 2020

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.7759018 +0.22414899 123.81735 -1.5443115
1 5000 6.327785 +0.27587223 131.29135 -0.416214
1 10000 12.276299 +0.6381073 137.72751 -4.2645416
1 50000 60.139835 +2.1484528 173.59052 -1.5612946
1 100000 114.09986 -2.492073 224.73181 -3.2652283
10 100 2.2414997 +0.10348797 129.29688 +0.5996704
10 500 6.7415013 -0.12072563 135.10196 +2.108963
10 1000 13.534715 +0.7413864 140.07893 -3.76091
10 5000 63.77737 +0.3435402 179.14224 -0.5960388
10 10000 126.102806 +5.649826 234.72899 +10.776138

@djaglowski djaglowski merged commit e91ef0c into master Dec 10, 2020
@djaglowski djaglowski deleted the flusher-stop branch December 10, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants