Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sane default value for sql server max_reads #288

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jun 24, 2021

Sometimes sql server plugin will give a "too many open files" error, this is because Windows by default will allow no more than 512 open file handles for a given process. We should set a sane default.

More context, the Windows event operator defaults to 100 for max_reads, so the plugin should as well. The user is free to increase this value if they want.

@jsirianni jsirianni marked this pull request as ready for review June 24, 2021 21:22
Copy link
Contributor

@asenkowski asenkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@BinaryFissionGames BinaryFissionGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlserver.yaml, line 27 -- # {{$max_reads := default 1000 .max_reads}} should be # {{$max_reads := default 100 .max_reads}}

Otherwise looks good!

@jsirianni
Copy link
Member Author

sqlserver.yaml, line 27 -- # {{$max_reads := default 1000 .max_reads}} should be # {{$max_reads := default 100 .max_reads}}

Otherwise looks good!

Good catch, thanks

@jsirianni jsirianni merged commit 003268e into master Jun 24, 2021
@jsirianni jsirianni deleted the sql-server-max-reads branch June 24, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants