-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Topology Processor #1988
Merged
colelaven
merged 28 commits into
release/v1.68.0
from
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
Dec 19, 2024
Merged
feat: Topology Processor #1988
colelaven
merged 28 commits into
release/v1.68.0
from
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colelaven
force-pushed
the
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
branch
from
November 21, 2024 20:53
4464bd6
to
f3a3766
Compare
colelaven
force-pushed
the
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
branch
from
November 21, 2024 22:13
84cf783
to
145cf72
Compare
colelaven
force-pushed
the
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
branch
from
December 12, 2024 04:04
4f63e21
to
5da9bb3
Compare
dpaasman00
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, some comments, otherwise looking good.
dpaasman00
force-pushed
the
release/v1.67.0
branch
from
December 16, 2024 20:06
104caa3
to
40fbb1f
Compare
colelaven
force-pushed
the
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
branch
3 times, most recently
from
December 18, 2024 14:12
d771f1b
to
c03794f
Compare
* Properly shut down chronicleexporter zombie goroutine * Fix lint * Fix the same problem for the GRPC workflow
colelaven
force-pushed
the
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
branch
from
December 18, 2024 16:51
6ed703c
to
52939be
Compare
dpaasman00
reviewed
Dec 19, 2024
dpaasman00
reviewed
Dec 19, 2024
dpaasman00
reviewed
Dec 19, 2024
dpaasman00
approved these changes
Dec 19, 2024
colelaven
deleted the
cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source
branch
December 19, 2024 14:34
dpaasman00
pushed a commit
that referenced
this pull request
Jan 7, 2025
* fix: Shut down zombie goroutine in chronicleexporter (#2029) * Properly shut down chronicleexporter zombie goroutine * Fix lint * Fix the same problem for the GRPC workflow * initial structure & getting headers * progress * custom messages sending & receiving properly * more progress * more changes * cleanup * dont use TopologyInterval, TODO: remove TopologyInterval from BP Extension * cleanup * cleanup & tests * rm print statements * cleanup, tests, fix tests * fix bp extension logic, fix lint * add gatewayid parameter * fix concurrent map write * fix tests * fix test * cleanup names & data model, add ResourceNameHeader * fix resource name header * address pr feedback * fix lint * repo rename fixes * fix rebase issue * fix gomod versions * fix go mod * update topo proc go mod * fix flaky test * bump version to 1.68.0 --------- Co-authored-by: Ian Adams <ian.sam.adams@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds topology processor used for gateway topology project
Checklist