Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Topology Processor #1988

Conversation

colelaven
Copy link
Contributor

@colelaven colelaven commented Nov 21, 2024

Proposed Change

Adds topology processor used for gateway topology project

Checklist
  • Changes are tested
  • CI has passed

@colelaven colelaven force-pushed the cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source branch from 4464bd6 to f3a3766 Compare November 21, 2024 20:53
@colelaven colelaven changed the title feat: topology processor feat: Topology Processor Nov 21, 2024
@colelaven colelaven changed the base branch from release/v1.65.0 to release/v1.66.0 November 21, 2024 22:11
@colelaven colelaven force-pushed the cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source branch from 84cf783 to 145cf72 Compare November 21, 2024 22:13
@colelaven colelaven marked this pull request as ready for review November 22, 2024 21:37
@colelaven colelaven requested review from dpaasman00 and a team as code owners November 22, 2024 21:37
@colelaven colelaven force-pushed the cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source branch from 4f63e21 to 5da9bb3 Compare December 12, 2024 04:04
@colelaven colelaven changed the base branch from release/v1.66.0 to release/v1.67.0 December 12, 2024 04:07
Copy link
Contributor

@dpaasman00 dpaasman00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, some comments, otherwise looking good.

extension/bindplaneextension/extension.go Outdated Show resolved Hide resolved
extension/bindplaneextension/go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
processor/topologyprocessor/go.mod Outdated Show resolved Hide resolved
processor/topologyprocessor/README.md Outdated Show resolved Hide resolved
processor/topologyprocessor/README.md Outdated Show resolved Hide resolved
processor/topologyprocessor/go.mod Outdated Show resolved Hide resolved
processor/topologyprocessor/go.mod Outdated Show resolved Hide resolved
@colelaven colelaven requested a review from dpaasman00 December 16, 2024 16:07
@colelaven colelaven force-pushed the cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source branch 3 times, most recently from d771f1b to c03794f Compare December 18, 2024 14:12
@colelaven colelaven force-pushed the cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source branch from 6ed703c to 52939be Compare December 18, 2024 16:51
@colelaven colelaven changed the base branch from release/v1.67.0 to release/v1.68.0 December 18, 2024 16:51
go.mod Outdated Show resolved Hide resolved
@colelaven colelaven merged commit 0c80959 into release/v1.68.0 Dec 19, 2024
15 checks passed
@colelaven colelaven deleted the cole/bpop-1180-create-topology-processor-add-to-bindplane-gateway-source branch December 19, 2024 14:34
dpaasman00 pushed a commit that referenced this pull request Jan 7, 2025
* fix: Shut down zombie goroutine in chronicleexporter (#2029)

* Properly shut down chronicleexporter zombie goroutine

* Fix lint

* Fix the same problem for the GRPC workflow

* initial structure & getting headers

* progress

* custom messages sending & receiving properly

* more progress

* more changes

* cleanup

* dont use TopologyInterval, TODO: remove TopologyInterval from BP Extension

* cleanup

* cleanup & tests

* rm print statements

* cleanup, tests, fix tests

* fix bp extension logic, fix lint

* add gatewayid parameter

* fix concurrent map write

* fix tests

* fix test

* cleanup names & data model, add ResourceNameHeader

* fix resource name header

* address pr feedback

* fix lint

* repo rename fixes

* fix rebase issue

* fix gomod versions

* fix go mod

* update topo proc go mod

* fix flaky test

* bump version to 1.68.0

---------

Co-authored-by: Ian Adams <ian.sam.adams@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants