Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react-native.config.js for RN 0.60 compat #1029

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

thymikee
Copy link
Contributor

React Native 0.60 is right behind the corner and it comes with latest CLI that now expects the RN config to live in react-native.config.js, while "rnpm" gets deprecated. Here's the docs on dependencies which in CLI terms are libraries like this one.

I'm not removing "rnpm" entry for now, since I'm not sure if you plan to support multiple RN versions with a single version of vector-icons) and they can happily live next to each other. Feel free to remove it later though :)

@hampustagerud
Copy link
Collaborator

Thanks for the heads up 😄👍

@hampustagerud hampustagerud merged commit 65c5229 into oblador:master Jun 26, 2019
@thymikee thymikee deleted the patch-1 branch June 27, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants