-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use http server for file references in chrome.app #472
Conversation
3d6b74d
to
2d19eb9
Compare
@oblador Not sure about the unit test failing. It doesn't seem to be able to get a port in the lambda container. |
17e22e1
to
016c31a
Compare
@oblador I tweaked solution to not use static file server with lambda renderer as I think there's some networking thing to solve. Rather than try to solve that now, I opted for fixing it it for I think the Docker tests are a bit flaky. The same failure on the last |
Hi team, any progress on this? It'd be nice to use Loki with Storybook 7 without any of the issues. Thank you. |
The static file server was previously added to the Docker target (#461), but it also needed to be added to the app target (for when you need to run Loki without Docker, e.g. in CI). I have copied the relevant changes over and moved shared modules into
core
.Fixes #471 and #465