Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose object_safe property on type Trait #320

Closed
obi1kenobi opened this issue Jan 13, 2024 · 6 comments
Closed

Expose object_safe property on type Trait #320

obi1kenobi opened this issue Jan 13, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@obi1kenobi
Copy link
Owner

Rustdoc as of format version 28 shows whether traits are object-safe or not: https://docs.rs/rustdoc-types/latest/rustdoc_types/struct.Trait.html#structfield.is_object_safe

We want to expose a new object_safe: Boolean! field on type Trait so we can query this information in cargo-semver-checks lints.

@devanbenz
Copy link
Contributor

@obi1kenobi This is WeblWabl from the timclicks discord - we had a brief discussion about OSS contribs :D I think I'm going to take on this issue & obi1kenobi/cargo-semver-checks#635 since they are dependencies.

@obi1kenobi
Copy link
Owner Author

Nice! Look at how type Trait implements its unsafe property, you can use its implementation as a guide since it should be quite analogous.

@devanbenz
Copy link
Contributor

@obi1kenobi Can I get permission to push to the github repository? I don't think I have read rights 🤔

@obi1kenobi
Copy link
Owner Author

obi1kenobi commented Feb 10, 2024 via email

@devanbenz
Copy link
Contributor

We could probably link this commit to the issue and close it out now :D #323

@obi1kenobi
Copy link
Owner Author

Nice! Resolved in #323 and published in v28.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants