-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose object_safe
property on type Trait
#320
Comments
@obi1kenobi This is WeblWabl from the timclicks discord - we had a brief discussion about OSS contribs :D I think I'm going to take on this issue & obi1kenobi/cargo-semver-checks#635 since they are dependencies. |
Nice! Look at how |
@obi1kenobi Can I get permission to push to the github repository? I don't think I have read rights 🤔 |
Could you try forking the repo and opening a PR that way? The publishing
config is a bit sensitive here so I'd rather not mess with the permissions
if it's possible to avoid it right now.
…On Fri, Feb 9, 2024, 10:19 PM WeblWabl ***@***.***> wrote:
@obi1kenobi <https://github.com/obi1kenobi> Can I get permission to push
to the github repository? I don't think I have read rights 🤔
—
Reply to this email directly, view it on GitHub
<#320 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5MSQEQRFEPM5S4M6UYILYS3RNDAVCNFSM6AAAAABBZCT2VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWHAZTKMZTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
We could probably link this commit to the issue and close it out now :D #323 |
Nice! Resolved in #323 and published in v28.0.2. |
Rustdoc as of format version 28 shows whether traits are object-safe or not: https://docs.rs/rustdoc-types/latest/rustdoc_types/struct.Trait.html#structfield.is_object_safe
We want to expose a new
object_safe: Boolean!
field ontype Trait
so we can query this information in cargo-semver-checks lints.The text was updated successfully, but these errors were encountered: