Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split each source code in test_crates/ into pair of crates #203

Merged
merged 28 commits into from
Dec 13, 2022
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
feb95b1
Split each source code in test_crates/ into pair of crates
tonowak Dec 2, 2022
a2e7f9c
Review changes
tonowak Dec 3, 2022
e43fe7c
Changed `expect` string style
tonowak Dec 4, 2022
3bdaf43
Changed `expect` string style
tonowak Dec 4, 2022
bd42fd9
Removed some small stuff I missed during splitting
tonowak Dec 4, 2022
5cc0964
Merge branch 'main' into split_test_crates
obi1kenobi Dec 5, 2022
1cbb9dd
Regenerated test outputs
tonowak Dec 5, 2022
89fd8e2
Added in
tonowak Dec 5, 2022
98b28a9
Merge branch 'main' into split_test_crates
obi1kenobi Dec 7, 2022
ce34cab
Changed script to ignore `README.md` in `test_crates/`
tonowak Dec 7, 2022
2986eca
Regenerated output after `trustfall_core` bugfix
tonowak Dec 7, 2022
d7497d9
Split `item_missing` into multiple crate pairs
tonowak Dec 9, 2022
4394090
Created a map of results instead of flattening them, changed test out…
tonowak Dec 9, 2022
e8e990d
Forgot to fmt
tonowak Dec 9, 2022
9795cd7
Renamed all `src/main.rs` to `src/lib.rs` in test crate pairs
tonowak Dec 9, 2022
1dc2049
Seems clippy doesn't work locally for me, I'll need to inspect this
tonowak Dec 9, 2022
8cfa0b8
Changed key values in top-level map in outputs
tonowak Dec 9, 2022
ae210f2
Updated `test_crates/README.md`
tonowak Dec 10, 2022
6912486
Merge branch 'main' into split_test_crates
tonowak Dec 10, 2022
9b67693
Updated `CONTRIBUTING.md`
tonowak Dec 10, 2022
1ea9a64
Self-review
tonowak Dec 10, 2022
03c8333
Ran clippy and fmt on crate pairs
tonowak Dec 10, 2022
ddc88ec
Shortened iteration over map
tonowak Dec 11, 2022
2dca44f
Changed wording in `test_crates/README.md`
tonowak Dec 11, 2022
0f9b7ec
Attempt at fixing pub_use_handling test
tonowak Dec 11, 2022
c2f1b54
Moved a description from `README.md` to CONTRIBUTING.md`
tonowak Dec 11, 2022
1e55360
Changed tabs to spaces
tonowak Dec 11, 2022
d2fb843
Changed some unwraps to expects
tonowak Dec 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions test_outputs/method_parameter_count_changed.output.ron
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,31 @@
"span_begin_line": Uint64(20),
"span_filename": String("src/main.rs"),
"visibility_limit": String("public")
},
{
"current_parameter_count": List([]),
"method_name": String("will_be_removed_associated_fn"),
"method_visibility": String("public"),
"name": String("Foo"),
"non_matching_span_begin_line": List([]),
"non_matching_span_filename": List([]),
"old_parameter_count": Uint64(0),
"path": List([String("item_missing"), String("Foo")]),
"span_begin_line": Uint64(15),
"span_filename": String("src/main.rs"),
"visibility_limit": String("public")
},
{
"current_parameter_count": List([]),
"method_name": String("will_be_removed_method"),
"method_visibility": String("public"),
"name": String("Foo"),
"non_matching_span_begin_line": List([]),
"non_matching_span_filename": List([]),
"old_parameter_count": Uint64(1),
"path": List([String("item_missing"), String("Foo")]),
"span_begin_line": Uint64(17),
"span_filename": String("src/main.rs"),
"visibility_limit": String("public")
tonowak marked this conversation as resolved.
Show resolved Hide resolved
}
]