Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated logical axiom of term OBI_0001898, issue #1050 #1053

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

zhengj2007
Copy link
Contributor

@jamesaoverton jamesaoverton changed the title updated logical axiom of term OBI_0001898, issue: https://github.com/… updated logical axiom of term OBI_0001898, issue #1050 Aug 23, 2019
@jamesaoverton
Copy link
Contributor

jamesaoverton commented Aug 23, 2019

Thanks @zhengj2007. I checked this locally by adding the axiom

continuant DisjointWith 'part of' some occurrent

then ran the reasoner. #1050 was fixed but I found another similar problem with OBI:0002053 'microarray assay measuring binding of a B cell epitope:antibody complex':

'assay measuring qualitiative binding of a B cell epitope:antibody complex'
and ('has part' some microarray)

I think it should be 'has part' some 'microarray assay'. I'll update this PR to fix that problem too.

@jamesaoverton jamesaoverton merged commit ed71871 into master Aug 23, 2019
@jamesaoverton jamesaoverton deleted the fix-issue1050 branch November 22, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants