fix: 'system' function is now independent of the 'shell' option.

lua/vfiler/items/file.lua

@@ -1,6 +1,5 @@
 local core = require('vfiler/libs/core')
 local fs = require('vfiler/libs/filesystem')
-local vim = require('vfiler/libs/vim')
 
 local File = {}
 
@@ -13,7 +12,7 @@ function File.create(path)
     command = ('touch "%s"'):format(path)
   end
 
-  local result = vim.fn.system(command)
+  local result = core.system(command)
   if #result > 0 then
     return nil
   end

lua/vfiler/libs/core.lua

@@ -43,6 +43,23 @@ function M.try(block)
   end
 end
 
+function M.system(expr)
+  local shell = vim.get_option('shell')
+  M.try({
+    function()
+      if M.is_windows then
+        vim.set_option('shell', 'cmd.exe')
+      else
+        vim.set_option('shell', '$SHELL')
+      end
+      vim.fn.system(expr)
+    end,
+    finally = function()
+      vim.set_option('shell', shell)
+    end,
+  })
+end
+
 ------------------------------------------------------------------------------
 -- Cursor
 ------------------------------------------------------------------------------

lua/vfiler/libs/filesystem.lua

@@ -190,12 +190,12 @@ end
 
 function M.copy_directory(src, dest)
   local command = copy_directory_format:format(escape(src), escape(dest))
-  return vim.fn.system(command)
+  return core.system(command)
 end
 
 function M.copy_file(src, dest)
   local command = copy_file_format:format(escape(src), escape(dest))
-  return vim.fn.system(command)
+  return core.system(command)
 end
 
 function M.execute(path)
@@ -234,7 +234,7 @@ function M.execute(path)
     core.message.error('Not supported platform.')
     return
   end
-  vim.fn.system(command)
+  M.system(command)
 end
 
 function M.move(src, dest)

lua/vfiler/libs/git.lua

@@ -19,7 +19,7 @@ end
 
 function M.get_toplevel(dirpath)
   local command = ('git -C "%s" rev-parse --show-toplevel'):format(dirpath)
-  local path = vim.fn.system(command)
+  local path = core.system(command)
   if (not path or #path == 0) or path:match('^fatal') then
     return nil
   end