Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed the cert value to all TAXII endpoints #89

Merged
merged 8 commits into from
Feb 9, 2021

Conversation

zrush-mitre
Copy link
Contributor

No description provided.

@zrush-mitre
Copy link
Contributor Author

Closes #86 ?

@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

Merging #89 (b0abfdc) into master (1135ca4) will decrease coverage by 0.04%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   95.27%   95.23%   -0.05%     
==========================================
  Files           8        8              
  Lines        1863     1867       +4     
==========================================
+ Hits         1775     1778       +3     
- Misses         88       89       +1     
Impacted Files Coverage Δ
taxii2client/common.py 81.87% <66.66%> (-0.44%) ⬇️
taxii2client/v20/__init__.py 91.10% <100.00%> (+0.02%) ⬆️
taxii2client/v21/__init__.py 91.56% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1135ca4...b0abfdc. Read the comment docs.

@zrush-mitre
Copy link
Contributor Author

This has been confirmed to work as expected using the PFTE as testing. I can't really think of a way to add a test to the testbed, since I don't know of a way to emulate SSL in a test file (I could do the encryption/decryption of stuff manually in a test, but I don't have a great understanding of exactly how it works on a practical level).

@clenk clenk merged commit 3ee5574 into oasis-open:master Feb 9, 2021
@emmanvg emmanvg added this to the 2.3.0 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants