[ML-177][Native Bayes] Fix error when converting Vector to CSRNumericTable #176
Conversation
2. add unit test for converting vector to CSRNumericTable Signed-off-by: minmingzhu <minming.zhu@intel.com>
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? Then could you also rename pull request title and commit log in the following format? See also: |
Signed-off-by: minmingzhu <minming.zhu@intel.com>
| @@ -53,7 +53,8 @@ suiteArray=( | |||
| "classification.MLlibNaiveBayesSuite" \ | |||
| "regression.MLlibLinearRegressionSuite" \ | |||
| "stat.MLlibCorrelationSuite" \ | |||
| "stat.MultivariateOnlineSummarizerSuite" | |||
| "stat.MultivariateOnlineSummarizerSuite" \ | |||
| "oneDALSuite" | |||
There was a problem hiding this comment.
could you put oneDALSuite in com.intel.oap.mllib namespace to align with oneDAL.scala
There was a problem hiding this comment.
if putting oneDALSuite in com.intel.oap.mllib, we can't use Matrices.fromVectors function to convert Vector to Matrix, because fromVectors function was private[ml]. In my opinion, we can distinguish more fine-grained into ML and MLLIb likes following image.
Signed-off-by: minmingzhu <minming.zhu@intel.com>
Pls follow this format to file an issue first and rename your PR title. Pls be more specific about what you want to do. same for #176 |
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package com.intel.oap.mllib; | |||
| package com.intel.oap; | |||
There was a problem hiding this comment.
Let's keep this inside oap mllib namespace. oap space is for the whole oap product. same below.
| @@ -236,7 +236,7 @@ object OneDAL { | |||
| matrixLabel | |||
| } | |||
|
|
|||
| private def vectorsToSparseNumericTable(vectors: Array[Vector], | |||
| def vectorsToSparseNumericTable(vectors: Array[Vector], | |||
| nFeatures: Long): CSRNumericTable = { | |||
There was a problem hiding this comment.
| nFeatures: Long): CSRNumericTable = { | |
| nFeatures: Long): CSRNumericTable = { |
Signed-off-by: minmingzhu <minming.zhu@intel.com>
|
@minmingzhu thanks for your work, I will fix the rest of this PR and merge. |
Signed-off-by: minmingzhu minming.zhu@intel.com
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Does this PR also require the following changes?