This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-821] Fix Wholestage Codegen on unsupported pattern #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2624b9e to
915a36a
Compare
This patch fixes wholestage codegen on unsupported pattern. The issue is introduced by a variant LeftOuter SortMergeJoin with Projection as its right child, which breaks the codegen depedency pattern. This patch introduced a check on this pattern and stop doing codegen under this case. Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
915a36a to
8c9385d
Compare
|
verified locally, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes wholestage codegen on unsupported pattern.
The issue is introduced by a variant LeftOuter SortMergeJoin
with Projection as its right child, which breaks the codegen
depedency pattern.
This patch introduced a check on this pattern and stop doing
codegen under this case.
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
pass jenkins