[RHELC-568] docs: improve failed conversion message #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As brought up in RHELC-568, the message when a conversion was unsuccessful wasn't ideal and needed to be changed. This PR fixes the message to hint at what the system is left in, that convert2rhel can't fix it by itself, and advise the user to restore a backup
for more information, see https://pre-commit.ci
Codecov ReportBase: 93.30% // Head: 93.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 22 22
Lines 3107 3107
Branches 552 552
=======================================
Hits 2899 2899
Misses 144 144
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Worked with docs team to get a better message
bocekm
previously requested changes
Oct 27, 2022
|
/packit test |
r0x0d
approved these changes
Nov 11, 2022
Merged
abadger
pushed a commit
to Andrew-ang9/convert2rhel
that referenced
this pull request
Dec 7, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Venefilyn
added a commit
that referenced
this pull request
Jun 19, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up in RHELC-568, the message when a conversion was unsuccessful wasn't ideal and needed to be changed. This PR fixes the message to hint at what the system is left in, that convert2rhel can't fix it by itself, and advise the user to restore a backup
Jira Issue: RHELC-568
Checklist
[RHELC-]is part of the PR titleRelease Pending