Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GPG key import and repository-related messages #547

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Jul 22, 2022

Repositories should not be abbreviated to "repos" in user facing messages.

The GPG key message was mentioning "keys" being imported while it referred to a single key.

Repositories should not be abbreviated to "repos" in user facing
messages.
The GPG key message was mentioning "keys" being imported while it
referred to a single key.
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #547 (8114672) into main (03e9700) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files          17       17           
  Lines        2458     2458           
  Branches      425      425           
=======================================
  Hits         2155     2155           
  Misses        241      241           
  Partials       62       62           
Impacted Files Coverage Δ
convert2rhel/checks.py 95.70% <ø> (ø)
convert2rhel/pkghandler.py 91.85% <50.00%> (ø)
convert2rhel/subscription.py 87.76% <50.00%> (ø)
convert2rhel/systeminfo.py 95.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e9700...8114672. Read the comment docs.

Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing is that codecov is pointing out that some lines are not covered by unit_tests. Would like to make them right now, or tackle this in another PR?

For me, I would say it's not something critical, and we can merge it.

@abadger
Copy link
Member

abadger commented Aug 30, 2022

I agree with @r0x0d that since the lines are presently not covered and the code inside is just to log messages when certain conditions are true that we don't have to add new unittests for those cases in this PR. Merging.

@abadger abadger merged commit adbafc7 into oamg:main Aug 30, 2022
@Venefilyn Venefilyn mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants