chore: replace percent strings for logging #1448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocekm
requested changes
Dec 11, 2024
| @@ -318,8 +318,7 @@ def format_pkg_info(pkgs, disable_repos=None): | |||
| max_nvra_length = max(len(nvra) for nvra in package_info) | |||
|
|
|||
| header = ( | |||
| "%-*s %-*s %s" | |||
There was a problem hiding this comment.
I've got this from Grok AI since it's been long since I wrote that code:
%-*s in print("%-*s" % (width, "text")) is a format specifier where: * means the width of the field is given by the first argument in the tuple (width in this case). - means left-align the text within that width. s means it's formatting a string.```
The format() replacement would look like print("{:<{}}".format("text", width)).
{:<{}} means: < aligns the text to the left. {} specifies the field width.```
There was a problem hiding this comment.
I checked on my own using https://pyformat.info/ and found a solution that looks a bit better
updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.3 → v0.8.2](astral-sh/ruff-pre-commit@v0.7.3...v0.8.2) - [github.com/teemtee/tmt.git: 1.38.0 → 1.39.0](https://github.com/teemtee/tmt.git/compare/1.38.0...1.39.0) - [github.com/jendrikseipp/vulture: v2.13 → v2.14](jendrikseipp/vulture@v2.13...v2.14)
This replaces logging with their best counterpart. Either normal logging methods with arguments, or by utilizing `.format()`
This changes `%-*s %-*s %s` %-string to their format counterpart `%-*s` = left-padded with next %-parameter indicating substring length or precision length.
bf0c24f to
d78a11d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 72 72
Lines 5176 5176
Branches 895 895
=======================================
Hits 4975 4975
Misses 119 119
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/packit test --labels sanity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces logging with their best counterpart. Either normal logging
methods with arguments, or by utilizing
.format()Depends on #1431