Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-1190] Add shim-x64 to the exclude list for Alma 8 #1039

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[RHELC-1190] Add shim-x64 to the exclude list for Alma 8 #1039

merged 2 commits into from
Feb 22, 2024

Conversation

r0x0d
Copy link
Member

@r0x0d r0x0d commented Jan 19, 2024 •
edited by bookwar
Loading

The package is causing dependency problem with the kernel-core package, as both of them are marked for downgrade. The dependencies does not match.

This solution is used for Oracle Linux 7 as well, as we simply add the package to the exclude list as well.

Jira Issues: RHELC-1190

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (773af3e) 94.92% compared to head (a4f1e66) 94.92%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files          50       50           
  Lines        4593     4593           
  Branches      816      816           
=======================================
  Hits         4360     4360           
  Misses        157      157           
  Partials       76       76
Flag Coverage Δ
centos-linux-7 89.98% <ø> (ø)
centos-linux-8 90.97% <ø> (ø)
centos-linux-9 91.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d added kind/bug-fix A bug has been fixed tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. labels Jan 19, 2024
@has-bot
Copy link
Member

has-bot commented Jan 19, 2024

/packit test --labels tier0

@oamg/conversions-qe please review results and provide ack.

@danmyway
Copy link
Member

/packit test --labels tier0

@pr-watson
Copy link
Contributor

@r0x0d does this still need to be in draft mode or is it ready for review?

@r0x0d r0x0d marked this pull request as ready for review January 30, 2024 16:49
@r0x0d
Copy link
Member Author

r0x0d commented Jan 30, 2024

@r0x0d does this still need to be in draft mode or is it ready for review?

Sorry, @pr-watson! Remove the draft status.

Based on my conversations with Jaroslav Mracek, it turns out that the idea of replacing the kernel between the transactions is not a good idea at all. The simplest and easiest solution for this one is to remove the package from the system before reaching the transaction.

@r0x0d
Copy link
Member Author

r0x0d commented Feb 15, 2024

/packit test --labels tier0

1 similar comment
@r0x0d
Copy link
Member Author

r0x0d commented Feb 19, 2024

/packit test --labels tier0

@r0x0d r0x0d force-pushed the update-alma-excludelist branch from 72a46c7 to d3208a9 Compare February 21, 2024 14:44
@danmyway
Copy link
Member

@r0x0d can you please remove this adjust so we can validate the fix? Thank you!

@r0x0d
Copy link
Member Author

r0x0d commented Feb 21, 2024

@r0x0d can you please remove this adjust so we can validate the fix? Thank you!

Sure!

@r0x0d
Copy link
Member Author

r0x0d commented Feb 21, 2024

/packit test --labels tier0

r0x0d and others added 2 commits February 21, 2024 14:12
@r0x0d @hosekadam
Update convert2rhel/data/8/x86_64/configs/almalinux-8-x86_64.cfg
6080eca 
Co-authored-by: Adam Hosek <hosek.adam@outlook.com>
@r0x0d
Update integration tests
a4f1e66 
Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
@r0x0d r0x0d force-pushed the update-alma-excludelist branch from 984025f to a4f1e66 Compare February 21, 2024 17:13
@r0x0d
Copy link
Member Author

r0x0d commented Feb 21, 2024

/packit test --labels tier0

@danmyway
Copy link
Member

Tested manually with EFI, works fine.

@bookwar bookwar self-requested a review February 22, 2024 14:38
@r0x0d r0x0d merged commit 596999d into oamg:main Feb 22, 2024
39 of 71 checks passed
@r0x0d r0x0d deleted the update-alma-excludelist branch February 22, 2024 14:43
@Venefilyn Venefilyn mentioned this pull request Feb 22, 2024
Merged
jochapma pushed a commit to jochapma/convert2rhel that referenced this pull request Mar 11, 2024
@r0x0d @hosekadam @jochapma
[RHELC-1190] Add shim-x64 to the exclude list for Alma 8 (oamg#1039)
e695ed6 
* Update convert2rhel/data/8/x86_64/configs/almalinux-8-x86_64.cfg

Co-authored-by: Adam Hosek <hosek.adam@outlook.com>

* Update integration tests

Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>

---------

Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
Co-authored-by: Adam Hosek <hosek.adam@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hosekadam hosekadam hosekadam left review comments

@bookwar bookwar bookwar approved these changes

Assignees
No one assigned
Labels
kind/bug-fix A bug has been fixed tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r0x0d @has-bot @danmyway @pr-watson @bookwar @hosekadam