Feat/button #136
Merged
Feat/button #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jimCresswell
reviewed
May 3, 2022
| }; | ||
| return ( | ||
| <Link {...nextLinkProps} passHref> | ||
| <a {...anchorProps} /> |
There was a problem hiding this comment.
would this benefit from role='button'? https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role
There was a problem hiding this comment.
Great question, followed a bit of a twitter search and ended up in this discussion: alphagov/govuk_elements#272
Basically, yes, we should add role='button' and add a "space" key handler which triggers onClick()!
jimCresswell
previously approved these changes
May 3, 2022
jimCresswell
approved these changes
May 3, 2022
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Buttoncomponent inline with figma designsIconButtoncomponentButtonOrLinkcomponent which renders eitherbuttonorLink(next/link) depending on if "href" or "onClick" passedLessonHeadercomponent based on figma designsBookmarkLessonButtonkebak-casecss classes tocamelCaseIssue(s)
Fixes #
How to test
Screenshots
How it should now look:
Checklist