-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boilerplate code #1
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oacore/search/5k4425pve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you copied most of the code. I do not very like it because it takes a lot of mess with it. Although, this is a better approach than creating the same mess from scratch. Let's refactor it step-by-step, I hope we will have time for it 👍
Some of my comments below describe the desired refactoring. They may be discussed but I expect them to be resolved with no action but another task is created instead ☝️
The code itself is hard to understand in some places, maybe because you were missing the context (it's my fault, sorry). Could you please simplify the code taking the following actions and ask for the review once again?
- We do not need the second page ❌
- The third page may be needed but later, but much later, you can either remove or store it somewhere. I propose to copy the branch and store it on GitHub but remove it from here
⚠️ - It would be nice to add a card around the form(s) but it can be done separately ✅
- I personally would like to merge templates back with the pages but it minor too ✅
@viktor-yakubiv Thanks for your review. Please have a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing extra pages. With your help, I managed to find which page exactly I should review. Please, remove a bit more extra code and I consider it's ready.
I created tasks for the conversations needed to resolve separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an awesome start 👍
Project structure is cloned from the github.com/oacore/dashboard but is simplified and adjusted to the current needs.
@viktor-yakubiv Consider this just basic boilerplate. I created templates for all three steps. We should probably merge it and start building registration on top of it. I still haven't figured out global store management. I think we don't need it for now. So it should be decided and added later.