-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table sidebar styling #196
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/oacore/dashboard/g9djbh2ea |
9cf0339
to
ace86da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okay to me. Please take a look at the behaviour I mentioned before. It should stay in the bottom but it can be improved later if you wish. Thank you for contributing 👍
// We want to pass referrer tag to our website | ||
// eslint-disable-next-line react/jsx-no-target-blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting issue. I see we have to add Button
to the list of components that the rule has to check. This comment should stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to configure it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the custom link components option.
Also, we may want to enable allow-referrer
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's quite clever 👍
Row gets rerendered automatically by MobX
Shows red header when fulltext is missing Position of footer in sidebar
No description provided.