Implement a ContactForm component #5

WebDevelopUa · 2019-01-09T15:09:06Z

No description provided.

viktor-yakubiv

Any input component should expose input method. In this case, when it's a form, the methods are onChange or onFieldChange, or onInputChange, onSubmit.

Also, a component should be configurable: it must have a props for options, action, method and so on.

components/contact-form/index.jsx

pages/about/index.jsx

components/contact-form/index.jsx

viktor-yakubiv · 2019-01-10T10:52:55Z

Please, always commit changes to pages and components in separate commits.

WebDevelopUa · 2019-01-14T11:30:05Z

Provide Reply-to field to contact form

Needs one more review

viktor-yakubiv

Improve component logic

viktor-yakubiv · 2019-01-15T15:50:41Z

components/contact-form/contact-form.scss

+.contact-form {
+  background-color: $gray-100;
+  position: relative;
+  //padding: 3em 1em 1em;


Clean code comments up

Other comments are not cleaned

viktor-yakubiv · 2019-01-15T15:51:39Z

components/contact-form/index.jsx

+  { value: 'field-three', label: 'Select field #3' },
+]
+
+const ContactForm = ({ action, method = 'post', onCancel }) => (


Provide more callbacks, at least onSubmit

components/contact-form/index.jsx

viktor-yakubiv · 2019-01-15T15:56:29Z

pages/about/index.jsx

+        >
+          Send us a message
+        </Button>
+        {isToggleOn && (


Consider usage Collapse-component from Reactstrap instead of pure removing of the element.

UncontrolledCollapse is good but we have to control it from two different points so we have to use controlled one with state.

viktor-yakubiv

Ask me if you have any question about the review.

viktor-yakubiv · 2019-01-22T09:37:34Z

components/contact-form/index.jsx

+  { value: 'field-three', label: 'Select field #3' },
+]
+
+const ContactForm = ({ action, method = 'post', onCancel, onSubmit }) => (


Pass options through props

viktor-yakubiv · 2019-01-22T09:38:05Z

components/contact-form/index.jsx

+
+const ContactForm = ({ action, method = 'post', onCancel, onSubmit }) => (
+  <Form className="contact-form my-3" action={action} method={method}>
+    <FormGroup className="pb-3" row>


Always avoid utility classes

viktor-yakubiv · 2019-01-22T09:40:02Z

components/contact-form/index.jsx

+          <option disabled selected>
+            Please choose a subject
+          </option>
+          {options.map(option => (


You can destructure option directly to { label, value }

components/contact-form/index.jsx

pages/about/index.jsx

* Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) * Fix/master content (#798) * HOTIFIX: search endpoint wasn't creating the right query * Master update from content (#795) * Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> --------- Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk> Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> * [feature] Design v4.9.0. Membership component (#796) * Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) * [feature] Design v4.9.0. Membership component * Fix/master content (#798) * HOTIFIX: search endpoint wasn't creating the right query * Master update from content (#795) * Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> --------- Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk> Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk> * Netlify config #4 * Netlify config #5 --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk>

* Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) * Fix/master content (#798) * HOTIFIX: search endpoint wasn't creating the right query * Master update from content (#795) * Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> --------- Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk> Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> * [feature] Design v4.9.0. Membership component (#796) * Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) * [feature] Design v4.9.0. Membership component * Fix/master content (#798) * HOTIFIX: search endpoint wasn't creating the right query * Master update from content (#795) * Update faq * add linking (#754) * fix missing buttons issue * feat: CORE-4429 open pdf in new tab * CORE-4429 babel config * update dependencies * [CORE-4431] docs-membership (#773) * update dataset text * CORE update api pdf file * CORE-4458 update terms page (#784) * update dataset text * CORE-4458: update terms page * temporary page * [bugfix] Config babel/runtime * Fix. Remove debug code (#794) --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> --------- Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk> Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk> * Netlify config #4 * Netlify config #5 * Netlify config #6 --------- Co-authored-by: mcancellieri <mcancellieri@users.noreply.github.com> Co-authored-by: ekachxaidze98 <65679299+ekachxaidze98@users.noreply.github.com> Co-authored-by: Eka <ekachxaidze2@gmail.com> Co-authored-by: Matteo Cancellieri <matteo.cancellieri@open.ac.uk>

* Netlify update #5 * Netlify update #6 * Netlify update #7

viktor-yakubiv requested changes Jan 10, 2019

View reviewed changes

viktor-yakubiv changed the title ~~add contact form view~~ Implement a ContactForm component Jan 14, 2019

viktor-yakubiv force-pushed the content branch from c7d5811 to 6bdb86e Compare January 15, 2019 15:38

viktor-yakubiv previously approved these changes Jan 15, 2019

View reviewed changes

viktor-yakubiv requested changes Jan 15, 2019

View reviewed changes

viktor-yakubiv force-pushed the content branch from fe39753 to edff28c Compare January 16, 2019 14:15

viktor-yakubiv changed the base branch from content to master January 22, 2019 09:35

viktor-yakubiv requested changes Jan 22, 2019

View reviewed changes

viktor-yakubiv force-pushed the contact branch 4 times, most recently from 69fe2e5 to c705b09 Compare February 1, 2019 12:13

viktor-yakubiv previously approved these changes Feb 1, 2019

View reviewed changes

WebDevelopUa and others added 3 commits February 1, 2019 14:17

implement ContactForm component

fedb4e1

add collapsing contact-form card

4007537

fix address alignment

3147799

viktor-yakubiv dismissed their stale review via 3147799 February 1, 2019 12:17

viktor-yakubiv force-pushed the contact branch from c705b09 to 3147799 Compare February 1, 2019 12:17

viktor-yakubiv merged commit 3147799 into master Feb 1, 2019

viktor-yakubiv deleted the contact branch February 3, 2019 08:32

valeriibudko added a commit that referenced this pull request Feb 11, 2023

Netlify config #5

400995c

valeriibudko mentioned this pull request Feb 11, 2023

Netlify membership files (#807) #808

Merged

valeriibudko added a commit that referenced this pull request Aug 4, 2023

Netlify update #5

d9badce

valeriibudko added a commit that referenced this pull request Aug 4, 2023

Netlify update #5 (#969)

9efe9e1

valeriibudko added a commit that referenced this pull request Aug 4, 2023

Netlify update #5 (#969) (#970)

cf6d6d4

valeriibudko added a commit that referenced this pull request Aug 4, 2023

Feature/netlify strucutre (#971)

f757cb9

* Netlify update #5 * Netlify update #6 * Netlify update #7

valeriibudko mentioned this pull request Aug 4, 2023

Feature/netlify strucutre (#971) #972

Merged

valeriibudko added a commit that referenced this pull request Aug 4, 2023

Feature/netlify strucutre (#971) (#972)

c9521d0

* Netlify update #5 * Netlify update #6 * Netlify update #7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a ContactForm component #5

Implement a ContactForm component #5

WebDevelopUa commented Jan 9, 2019

viktor-yakubiv left a comment

viktor-yakubiv commented Jan 10, 2019

WebDevelopUa commented Jan 14, 2019

viktor-yakubiv left a comment

viktor-yakubiv Jan 15, 2019

viktor-yakubiv Jan 22, 2019

viktor-yakubiv Jan 15, 2019

viktor-yakubiv Jan 15, 2019

viktor-yakubiv Jan 22, 2019

viktor-yakubiv left a comment

viktor-yakubiv Jan 22, 2019

viktor-yakubiv Jan 22, 2019

viktor-yakubiv Jan 22, 2019

Implement a ContactForm component #5

Implement a ContactForm component #5

Conversation

WebDevelopUa commented Jan 9, 2019

viktor-yakubiv left a comment

Choose a reason for hiding this comment

viktor-yakubiv commented Jan 10, 2019

WebDevelopUa commented Jan 14, 2019

viktor-yakubiv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viktor-yakubiv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment