Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional override #158

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Optional override #158

merged 1 commit into from
Jun 22, 2023

Conversation

sscotth
Copy link
Contributor

@sscotth sscotth commented Jun 21, 2023

I'd like to make overriding existing environment variables be optional. Something like this code should work:

@sscotth sscotth requested a review from oNaiPs as a code owner June 21, 2023 23:08
@oNaiPs
Copy link
Owner

oNaiPs commented Jun 22, 2023

@sscotth let me know what you think about the current PR state

@oNaiPs oNaiPs closed this Jun 22, 2023
@oNaiPs oNaiPs reopened this Jun 22, 2023
@sscotth
Copy link
Contributor Author

sscotth commented Jun 22, 2023

Looks good

@oNaiPs oNaiPs merged commit 13568fe into oNaiPs:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oNaiPs oNaiPs Awaiting requested review from oNaiPs oNaiPs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sscotth @oNaiPs