Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #958, have the proxy follow redirects #962

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

epugh
Copy link
Member

@epugh epugh commented Feb 27, 2024

Description

The Quepid proxy doesn't follow redirects, but if we get one...

Motivation and Context

Working with a custom serach api where their search ends with "http://blahblah/search/?q=tiktok"..... However, do to url parsing in the wizrd, that gets convert to "http://blahblah/search?q=tiktok", which then causes the client to want to do a redirect BACK to the "http://blahblah/search/?q=tiktok". Sigh.

Easier to change Quepid then the api!

How Has This Been Tested?

webmock test and manually

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh linked an issue Feb 27, 2024 that may be closed by this pull request
@epugh
Copy link
Member Author

epugh commented Feb 27, 2024

@wrigleyDan this one is for you!

@epugh epugh merged commit b6ca5c7 into main Feb 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quepid does not follow redirects in custom search API responses
1 participant