Add ForUserScope concern to DRY & simplify code #955
Conversation
| scope :for_user, ->(user) { | ||
| joins(' | ||
| LEFT OUTER JOIN teams_members on teams_members.team_id = teams.id | ||
| LEFT OUTER JOIN users on users.id = teams_members.member_id | ||
| ').where('`teams_members`.`member_id` = ?', user.id) | ||
| } |
There was a problem hiding this comment.
Team.for_user appears to be unused
|
This is very exciting! Will this reduce the number of queries we run? I believe right now we run three, one for the directly owned, one for the teams, then we pluck the id's, and then do a query for that! |
|
the test #create#test_alerts_when_a_scorer_associated_with_a_book_does_not_exist failing is my bad! |
test/models/case_test.rb
Outdated
There was a problem hiding this comment.
i notice only a test on case_test.rb is this becasue it would be basically the same darn test and reducndent for book and scorer?
There was a problem hiding this comment.
Yeah actually let me move these cases into a test file just for this concern, for clarity. Also, I'll add test cases for Scorer.for_user
| module ForUserScope | ||
| extend ActiveSupport::Concern | ||
|
|
||
| included do |
|
THank you fo rthis, I've pushed it out to app.quepid.com... It "feels" a bit faster... The homepage on app.quepid.com still struggles to load quickly sigh. |
Description
Most of these scopes are the same and only the
for_usercombined scope is used