Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for max query text length #952

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

epugh
Copy link
Member

@epugh epugh commented Feb 13, 2024

Description

Motivation and Context

This caught us recently with a very long "question" in a RAG situation..

We may want to lengthen the query...

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh
Copy link
Member Author

epugh commented Feb 13, 2024

@mkr do you think we should just make queries longer than 500? In your looking at logged queries was it relatively common?

@mkr
Copy link
Contributor

mkr commented Feb 13, 2024

@epugh It was very rare. I would stick with 500 for now.

@epugh epugh merged commit 50d2e6c into main Feb 15, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants