Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 32 broken agreement link #42

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Conversation

epugh
Copy link
Member

@epugh epugh commented Dec 18, 2019

Description

Introduce a configurationSvc that gets values from the server side rendered site into a Javascirpt var and into the fornt end app. Consult the configurationSvc.hasTermsAndConditions() to decide if we show the checkbox, and if so provide the URL.

Motivation and Context

We only fixed server side rendered URLS. Also, this is our first example of a configuration driven change to the behavior of quepid, the checkbox on T&Cs showing up or not.

How Has This Been Tested?

Wrote a spec for the service, and then tested by hand with TC_URL= and TC_URL=http://example.com/agreement to confirm checkbox behavior.

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit 34ca11c into master Dec 19, 2019
epugh added a commit that referenced this pull request Dec 19, 2019
@nathancday nathancday deleted the bugfix-32-broken-agreement-link branch March 13, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant