Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a
configurationSvc
that gets values from the server side rendered site into a Javascirpt var and into the fornt end app. Consult theconfigurationSvc.hasTermsAndConditions()
to decide if we show the checkbox, and if so provide the URL.Motivation and Context
We only fixed server side rendered URLS. Also, this is our first example of a configuration driven change to the behavior of quepid, the checkbox on T&Cs showing up or not.
How Has This Been Tested?
Wrote a spec for the service, and then tested by hand with
TC_URL=
andTC_URL=http://example.com/agreement
to confirm checkbox behavior.Screenshots or GIFs (if appropriate):
Types of changes
Checklist: