Clean up datamodel for case and query #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 12, 2020 07:50
…inder.rb however makign this change as one of our tests was flagging it as causing extra unrequired loads! also makes it the same as the others!
|
Looking at the hosted version of Quepid, interestingly we have 23036 deleted queries and only 18461 not deleted queries! |
|
BTW, I'm starting to think the soft delete might be useful... If I have a bunch of queries and ratings, do I want to lose them just because I don't want the query right now on my case? |
|
This work was subsumed in first the Rails 5 upgrade, and then in the work on #288, so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let cases and queries be deleted.
Motivation and Context
I started out looking at #250 about archiving a case being supported, but not deleting. Digging in, I realized that I don't know why we have a
soft_deletefunction on Queries. What is the point of being able to mark a query as deleted, but not actually delete it? Especially since soft deleting caused a bug in the snapshots, see #255. As far as I can tell, a soft deleted query is never undeleted.. And never used?So branching this out a bit to removing the soft delete function on a query. If you delete a query you delete the query!
How Has This Been Tested?
Screenshots or GIFs (if appropriate):
Types of changes
Checklist: